When running "fastd -v" fails, line may be NULL, causing a segfault in
strncmp.

for devices in targets that do no implement `get_status_led` in /etc/diag.sh
and do not have an led-running in their dts

Gone due to
commit 45c84a11 ("ar71xx: drop target")

Depending on the source of the primary MAC address, uppercase digits
would be used on some devices. Convert the address to lowercase for
consistency.

We only change the case for newly configured nodes to avoid changing the
node ID and derives MAC addresses for existing installations.

The ip6tables-legacy metapackage was renamed to ip6ables-zz-legacy.

Only restore the netifd proto for the WAN bridge in case the upgrade is
done from an older Gluon version.

For DSL targets, OpenWrt defaults the WAN proto to pppoe, while Gluon
uses the Ethernet ports for WAN. When unconditionally preserving the WAN
proto, pppoe is carried over to Gluon's network config.

Signed-off-by: David Bauer <mail@david-bauer.net>

Co-Authored-By: J. Burfeind <github@aiyionpri.me>

Co-authored-by: Tim-Niklas Koch <info@tnkoch.de>
Co-authored-by: J. Burfeind <github@aiyionpri.me>

There was never a device with a dedicated WAN port supported in Gluon
which could make use of such a workaround.

As the only relevant lantiq-xrx200 target now uses swconfig anyways,
we can remove this workaround.

Signed-off-by: David Bauer <mail@david-bauer.net>

Gone due to
commit 45c84a11 ("ar71xx: drop target")

posix-sh does not support pipefail this way

to prevent word splitting and globbing

OpenWrt now allows to specify the ifname of the transition interface
instead of SSID and BSSID, internally automatically detecting these from
interfaces on the same PHY. Thus, these cross-VAP dependant
configuration can be omitted from UCI.

Signed-off-by: David Bauer <mail@david-bauer.net>

Co-authored-by: Maximilian Baumgartner <aufhaxer@googlemail.com>

Gone due to
commit 45c84a11 ("ar71xx: drop target")

Gone due to
commit 071cf7b2 ("Switch to Lua for target definitions")

Has prior been introduced as untested -> broken in
commit d586720c ("ar71xx-generic: add support for Ubiquiti NanoBeam M5")

Was commented out in the former commit.

An invalid branch may be set for various reasons:

- Previous firmware had an invalid default branch
- Branch list has changed and old UCI branch config was removed by a
  site-specific upgrade script
- Manual UCI configuration

Make the code clearer and prepare for invalid branch fixup.

Check the default branch (both from site.conf and GLUON_AUTOUPDATER_BRANCH)
against the list of configured branch names to avoid misconfiguration.

The new "value" helper can be used to turn a Lua value into a path that
can be passed to need_*() etc.

Removed in 45c84a11 ("ar71xx: drop target").

Since freifunk-gluon/packages#250 mesh-vpn-peers
can be empty arrays if they're not connected
and the node is in a WireGuard site.

If a community uses different vpn providers, they typically
assume the same MTU for the wan device underneath the VPN. As
different VPN providers however have different overhead, the MTU
of the VPN device differs for each provider. Therefore this
commit makes the MTU of the VPN device provider specific.

This has two advantages:
1. The same site.conf can used to bake firmwares for different
   VPN providers (only by selecting a diferent vpn feature in the
   site.mk).
2. We are coming closer to the option of integrating multiple VPN
   providers into one firmware.

This folder is referenced in files/lib/netifd/proto/gluon_mesh.sh, but 
there's no .keep for it

Gone due to
commit 45c84a11 ("ar71xx: drop target")

This was removed in commit c23bc293 ("treewide: remove
GLUON_SPECIALIZE_KERNEL").

WolfSSL has a significant lower flash footprint. Also, issues with OWE /
SAE connections were fixed in OpenWrt a while ago.

See https://github.com/openwrt/openwrt/commit/ddcb970274c011d3db611ec39350ee4704ff0e02



Signed-off-by: David Bauer <mail@david-bauer.net>

Require legacy iptables, as Gluon still depends on firewall3. Otherwise,
nftables is pulled in as a dependency.

Instead of using roles.wan directly as the default for roles.single,
create a copy of the table, so subsequent modifications of roles.single
don't affect roles.wan as well.

Fixes migration of Mesh-on-WAN status when no default for "single"
interfaces is set in site.conf.

The function failed when an interface has no roles assigned, breaking
several upgrade scripts.

Closes #2471

Make the code match the docs and check_site.lua by actually looking up
the "default_roles" field, not "roles".

Gone due to
commit 45c84a11 ("ar71xx: drop target")