Skip to content
Snippets Groups Projects
Unverified Commit 701857ec authored by github-actions[bot]'s avatar github-actions[bot] Committed by GitHub
Browse files

targets.mk: fix inconsistent env variable BROKEN (#3103)


BROKEN TARGETS were built when BROKEN was set as a variable regardless of
it's value. Even an empty BROKEN variable caused BROKEN TARGETS to be
built. For DEVICES the number was evaluated and compared to true by Lua.

Make behavior consistent for relevant values UNSET/EMPTY/0 and 1:
UNSET/EMPTY/0: Don't build BROKEN TARGETS and DEVICES
1: Build BROKEN TARGETS and DEVICES

The behavior remains inconsistent for all positive numbers except 1.
(even floating point)

(cherry picked from commit bc8778cd1e6c2317003fcd688e663fd1549b7fc8)

Co-authored-by: default avatarFelix Baumann <felix.bau@gmx.de>
parent c59d0703
No related branches found
No related tags found
No related merge requests found
...@@ -23,7 +23,7 @@ $(eval $(call GluonTarget,x86,legacy)) ...@@ -23,7 +23,7 @@ $(eval $(call GluonTarget,x86,legacy))
$(eval $(call GluonTarget,x86,64)) $(eval $(call GluonTarget,x86,64))
ifneq ($(BROKEN),) ifeq ($(BROKEN),1)
$(eval $(call GluonTarget,bcm27xx,bcm2710)) # BROKEN: Untested $(eval $(call GluonTarget,bcm27xx,bcm2710)) # BROKEN: Untested
$(eval $(call GluonTarget,mvebu,cortexa9)) # BROKEN: No 11s support $(eval $(call GluonTarget,mvebu,cortexa9)) # BROKEN: No 11s support
endif endif
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment