From 701857ecd445c0f495cf6b4b6cadd1f95c41bda0 Mon Sep 17 00:00:00 2001
From: "github-actions[bot]"
 <41898282+github-actions[bot]@users.noreply.github.com>
Date: Wed, 13 Dec 2023 08:57:25 +0100
Subject: [PATCH] targets.mk: fix inconsistent env variable BROKEN (#3103)

BROKEN TARGETS were built when BROKEN was set as a variable regardless of
it's value. Even an empty BROKEN variable caused BROKEN TARGETS to be
built. For DEVICES the number was evaluated and compared to true by Lua.

Make behavior consistent for relevant values UNSET/EMPTY/0 and 1:
UNSET/EMPTY/0: Don't build BROKEN TARGETS and DEVICES
1: Build BROKEN TARGETS and DEVICES

The behavior remains inconsistent for all positive numbers except 1.
(even floating point)

(cherry picked from commit bc8778cd1e6c2317003fcd688e663fd1549b7fc8)

Co-authored-by: Felix Baumann <felix.bau@gmx.de>
---
 targets/targets.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/targets/targets.mk b/targets/targets.mk
index 346377ea3..d5f605aaf 100644
--- a/targets/targets.mk
+++ b/targets/targets.mk
@@ -23,7 +23,7 @@ $(eval $(call GluonTarget,x86,legacy))
 $(eval $(call GluonTarget,x86,64))
 
 
-ifneq ($(BROKEN),)
+ifeq ($(BROKEN),1)
 $(eval $(call GluonTarget,bcm27xx,bcm2710)) # BROKEN: Untested
 $(eval $(call GluonTarget,mvebu,cortexa9)) # BROKEN: No 11s support
 endif
-- 
GitLab