Skip to content
Snippets Groups Projects
  • github-actions[bot]'s avatar
    701857ec
    targets.mk: fix inconsistent env variable BROKEN (#3103) · 701857ec
    github-actions[bot] authored
    
    BROKEN TARGETS were built when BROKEN was set as a variable regardless of
    it's value. Even an empty BROKEN variable caused BROKEN TARGETS to be
    built. For DEVICES the number was evaluated and compared to true by Lua.
    
    Make behavior consistent for relevant values UNSET/EMPTY/0 and 1:
    UNSET/EMPTY/0: Don't build BROKEN TARGETS and DEVICES
    1: Build BROKEN TARGETS and DEVICES
    
    The behavior remains inconsistent for all positive numbers except 1.
    (even floating point)
    
    (cherry picked from commit bc8778cd1e6c2317003fcd688e663fd1549b7fc8)
    
    Co-authored-by: default avatarFelix Baumann <felix.bau@gmx.de>
    targets.mk: fix inconsistent env variable BROKEN (#3103)
    github-actions[bot] authored
    
    BROKEN TARGETS were built when BROKEN was set as a variable regardless of
    it's value. Even an empty BROKEN variable caused BROKEN TARGETS to be
    built. For DEVICES the number was evaluated and compared to true by Lua.
    
    Make behavior consistent for relevant values UNSET/EMPTY/0 and 1:
    UNSET/EMPTY/0: Don't build BROKEN TARGETS and DEVICES
    1: Build BROKEN TARGETS and DEVICES
    
    The behavior remains inconsistent for all positive numbers except 1.
    (even floating point)
    
    (cherry picked from commit bc8778cd1e6c2317003fcd688e663fd1549b7fc8)
    
    Co-authored-by: default avatarFelix Baumann <felix.bau@gmx.de>