Skip to content
Snippets Groups Projects
  1. Sep 15, 2014
  2. Sep 11, 2014
  3. Sep 09, 2014
  4. Sep 06, 2014
  5. Sep 03, 2014
  6. Aug 30, 2014
  7. Aug 28, 2014
  8. Aug 27, 2014
    • NeoRaider's avatar
      Merge pull request #68 from FreifunkBremen/gluon-cron-fix · 9d11f4bd
      NeoRaider authored
      gluon-cron: Fix endless loop parsing invalid lines
      9d11f4bd
    • Jan-Philipp Litza's avatar
      gluon-cron: Fix endless loop parsing invalid lines · afce06c3
      Jan-Philipp Litza authored
      Using the line
      ```
      * * * * echo "foobar"
      ```
      (notice the missing fifth time field) in a crontab causes gluon-cron
      to enter an endless loop while parsing it, thus it won't even execute
      the other, valid crontabs.
      
      This is caused by the loop in [line 138] where `begin - min`
      substracts the unsigned `min` from the signed `begin`. If now `begin`
      is invalid, `strict_atoi` returns -1 and the loop starts at
      `(-1)-1=MAX_INT` and runs while `i <= MAX_INT` which is always true.
      
      The real culprit lies in [line 134] where exactly this case
      `begin < min` is checked - but because of the signedness, this check doesn't
      work as expected either.
      
      The easiest solution is to make `min` a signed integer instead of an unsigned
      one, as we do not require it to be very large and only pass the constants 0 or
      1 to it.
      
      To avoid other similar problems, this patch makes the input variable `n` a
      signed integer as well.
      afce06c3
  9. Aug 25, 2014
  10. Aug 22, 2014
  11. Aug 18, 2014
  12. Aug 17, 2014
  13. Aug 16, 2014
  14. Aug 15, 2014
  15. Aug 10, 2014
  16. Aug 09, 2014
Loading