From 4e847f7eef8ce143afd8ade72b56d9f49013e414 Mon Sep 17 00:00:00 2001
From: Matthias Schiffer <mschiffer@universe-factory.net>
Date: Fri, 28 Mar 2025 16:54:30 +0100
Subject: [PATCH] hardware: remove support for D-Link DGS-1210-10P and
 realtek-rtl838x target

This device should never have been supported as non-broken. It is not a
useful target for batman-adv (as the CPU is too slow for reasonable
throughput; it may be more useful with L3 routing protocols); also, the
autoupdater never worked because of an incorrect image name.

As there it nobody actually running this device (or planning to do so
at the moment), just drop the device instead of fixing the name. The
realtek-rtl838x target becomes empty and is dropped.
---
 .github/filters.yml                                    | 10 ----------
 docs/user/supported_devices.rst                        |  7 -------
 .../gluon-core/luasrc/lib/gluon/upgrade/020-interfaces |  4 ----
 targets/realtek-rtl838x                                |  5 -----
 targets/targets.mk                                     |  1 -
 5 files changed, 27 deletions(-)
 delete mode 100644 targets/realtek-rtl838x

diff --git a/.github/filters.yml b/.github/filters.yml
index aa6ea75da..df82429fa 100644
--- a/.github/filters.yml
+++ b/.github/filters.yml
@@ -205,16 +205,6 @@
     "targets/generic",
     "targets/targets.mk"
   ],
-  "realtek-rtl838x": [
-    "targets/realtek-rtl838x",
-    ".github/workflows/build-gluon.yml",
-    "modules",
-    "Makefile",
-    "patches/**",
-    "scripts/**",
-    "targets/generic",
-    "targets/targets.mk"
-  ],
   "rockchip-armv8": [
     "targets/rockchip-armv8",
     ".github/workflows/build-gluon.yml",
diff --git a/docs/user/supported_devices.rst b/docs/user/supported_devices.rst
index 3c6d28bb2..a0aa0aad2 100644
--- a/docs/user/supported_devices.rst
+++ b/docs/user/supported_devices.rst
@@ -544,13 +544,6 @@ ramips-mt76x8
   - Xiaomi Mi Router 4A (100M International Edition)
   - Xiaomi Mi Router 4C
 
-realtek-rtl838x
----------------
-
-* D-Link
-
-  - DGS-1210-10P (F1)
-
 rockchip-armv8
 --------------
 
diff --git a/package/gluon-core/luasrc/lib/gluon/upgrade/020-interfaces b/package/gluon-core/luasrc/lib/gluon/upgrade/020-interfaces
index a36534928..2f5b770bd 100755
--- a/package/gluon-core/luasrc/lib/gluon/upgrade/020-interfaces
+++ b/package/gluon-core/luasrc/lib/gluon/upgrade/020-interfaces
@@ -83,10 +83,6 @@ elseif platform.match('lantiq', 'xrx200', {
 	'arcadyan,vgv7510kw22-nor',
 }) then
 	lan_ifname, wan_ifname = 'lan1 lan2 lan3 lan4', 'wan'
-elseif platform.match('realtek', 'rtl838x', {
-	'd-link,dgs-1210-10p',
-}) then
-	lan_ifname, wan_ifname = 'lan2 lan3 lan4 lan5 lan6 lan7 lan8 lan9 lan10', 'lan1'
 end
 
 if wan_ifname and lan_ifname then
diff --git a/targets/realtek-rtl838x b/targets/realtek-rtl838x
deleted file mode 100644
index f78c9ed2c..000000000
--- a/targets/realtek-rtl838x
+++ /dev/null
@@ -1,5 +0,0 @@
--- D-Link
-
-device('d-link_dgs-1210-10p', 'd-link_dgs-1210-10p', {
-	factory = '-squashfs-factory_image1',
-})
diff --git a/targets/targets.mk b/targets/targets.mk
index 1ee2fe7c3..2a47e959d 100644
--- a/targets/targets.mk
+++ b/targets/targets.mk
@@ -18,7 +18,6 @@ $(eval $(call GluonTarget,mpc85xx,p1020))
 $(eval $(call GluonTarget,ramips,mt7620))
 $(eval $(call GluonTarget,ramips,mt7621))
 $(eval $(call GluonTarget,ramips,mt76x8))
-$(eval $(call GluonTarget,realtek,rtl838x))
 $(eval $(call GluonTarget,rockchip,armv8))
 $(eval $(call GluonTarget,sunxi,cortexa7))
 $(eval $(call GluonTarget,x86,generic))
-- 
GitLab