From c07cefe5d2373a47d898a40ae8c51c2659414136 Mon Sep 17 00:00:00 2001 From: Little-Ben <Little-Ben@users.noreply.github.com> Date: Tue, 3 Sep 2019 19:38:07 +0200 Subject: [PATCH] fix RegExp FileExtension reFileExtension had a problem caused false replacing of extensions (for examble extension "ubi" replaced ubi in ubiquity and left extension "bin") e.g. file: gluon-comm-0.1.2-stable.0-20190722-ubiquiti-unifi-ac-mesh-sysupgrade.bin would have been (wrong): quiti-unifi-ac-mesh-.bin.jpg instead of (correct): ubiquiti-unifi-ac-mesh.jpg should fix (at least parts) of #92 not sure if the first point in line 123 should also be escape RegExp(/.(bin|img\.gz|img|tar|ubi)$/); RegExp(/\.(bin|img\.gz|img|tar|ubi)$/); --- app.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app.js b/app.js index 0570e37..8ba1e72 100644 --- a/app.js +++ b/app.js @@ -120,7 +120,7 @@ var firmwarewizard = function() { return index === self.indexOf(e); }); - var reFileExtension = new RegExp(/.(bin|img.gz|img|tar|ubi)/); + var reFileExtension = new RegExp(/.(bin|img\.gz|img|tar|ubi)$/); var reRemoveDashes = new RegExp(/-/g); var reSearchable = new RegExp('[-/ '+NON_BREAKING_SPACE+']', 'g'); var reRemoveSpaces = new RegExp(/ /g); -- GitLab